Re: [Qemu-devel] [PATCH] Fix a compile error when none of the defines is hit

[Anthony Liguori]

Liu Yu wrote:
> Signed-off-by: Liu Yu <address@hidden>
>   

What particularly circumstance would this be, --disable-sdl?

> ---
>  vl.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 63d954b..1bf13c0 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -5548,6 +5548,8 @@ int main(int argc, char **argv, char **envp)
>                      sdl_display_init(ds, full_screen, no_frame);
>  #elif defined(CONFIG_COCOA)
>                      cocoa_display_init(ds, full_screen);
> +#else
> +                   ;
>   

I'd rather see something like do {} while (0); with a comment.

Regards,

Anthony Liguori

>  #endif
>              }
>      }
>