Re: [Qemu-devel] [6392] Add BIOS fixes from KVM tree

[Carl-Daniel Hailfinger]

Hi,

I'm sorry to say that, but my tests showed that
0004_kvm-bios-add-mtrr-support.patch is buggy. It reads MSR_MTRRcap
unconditionally which is not allowed if the CPUID features do not have
CPUID_MTRR set. Real hardware will #GP in that case.
This was found by my MSR access tracing patch.

Please add a check for the CPUID_MTRR feature bit before reading
MSR_MTRRcap. Thanks.

Regards,
Carl-Daniel

On 21.01.2009 22:46, Anthony Liguori wrote:
> Revision: 6392
>           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6392
> Author:   aliguori
> Date:     2009-01-21 21:46:20 +0000 (Wed, 21 Jan 2009)
>
> Log Message:
> -----------
> Add BIOS fixes from KVM tree
>
> See each patch for individual Signed-off-by's/commit logs
>
> [...]
> Added Paths:
> -----------
>     
> trunk/pc-bios/bios-pq/0002_kvm-bios-update-smbios-table-to-report-memory-above-4g.patch
>     trunk/pc-bios/bios-pq/0003_kvm-bios-generate-mptable-unconditionally.patch
>     trunk/pc-bios/bios-pq/0004_kvm-bios-add-mtrr-support.patch
>     trunk/pc-bios/bios-pq/0005_kvm-bios-smp-mtrr-support.patch
>     trunk/pc-bios/bios-pq/0006_kvm-bios-extend-mtrrs-to-above-4g.patch
>     
> trunk/pc-bios/bios-pq/0007_kvm-bios-cleanup-consolidate-above-4g-memory-parsing.patch
>     
> trunk/pc-bios/bios-pq/0008_kvm-bios-switch-mtrrs-to-cover-only-the-pci-range-and--default-to-wb.patch
>     
> trunk/pc-bios/bios-pq/0009_kvm-bios-resolve-memory-device-roll-over-reporting--issues-with-32g-guests.patch
>     
> trunk/pc-bios/bios-pq/0010_kvm-bios-fix-smbios-memory-device-length-boundary--condition.patch
>   
-- 
http://www.hailfinger.org/