Re: [Qemu-devel] [PATCH] install man-pages as non-executables

[Anthony Liguori]

Andre Przywara wrote:
> make install-doc omits an explicit permission mask for the man-pages. This
> defaults to have the executable bits set. Adding "-m 644" (for rw-r--r--)
> fixes that.
>
> Signed-off-by: Andre Przywara <address@hidden>
>   

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
>  Makefile |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 8cbdcda..fc7809d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -233,9 +233,9 @@ install-doc: $(DOCS)
>         $(INSTALL) -m 644 qemu-doc.html  qemu-tech.html "$(DESTDIR)$(docdir)"
>  ifndef CONFIG_WIN32
>         mkdir -p "$(DESTDIR)$(mandir)/man1"
> -       $(INSTALL) qemu.1 qemu-img.1 "$(DESTDIR)$(mandir)/man1"
> +       $(INSTALL) -m 644 qemu.1 qemu-img.1 "$(DESTDIR)$(mandir)/man1"
>         mkdir -p "$(DESTDIR)$(mandir)/man8"
> -       $(INSTALL) qemu-nbd.8 "$(DESTDIR)$(mandir)/man8"
> +       $(INSTALL) -m 644 qemu-nbd.8 "$(DESTDIR)$(mandir)/man8"
>  endif
>  
>  install: all $(if $(BUILD_DOCS),install-doc)
>