qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/2] Add phenom CPU descriptor


From: Alexander Graf
Subject: Re: [Qemu-devel] [PATCH 2/2] Add phenom CPU descriptor
Date: Wed, 28 Jan 2009 09:17:30 +0100





On 27.01.2009, at 23:39, Paul Brook <address@hidden> wrote:

I didn't apply this last time because I dislike the idea of adding
oodles of CPU definitions for x86. The proper thing to do here is to have an fdt based description of CPU model. That's not to say I won't apply this patch, but I don't like the idea of adding more and more of
these things.

Did you try "qemu-system-ppc -cpu ?" ;-) ?

Which is precisely what I'd like to avoid :-)

Although this is a bit different.  We aren't actually emulating a
phenom.  We're just taking what we have and calling it a phenom.  I
suspect there's going to be a desire to call whatever we emulate
arbitrary things.

I don't think we're likely to want the big list of cpus anyway.

The real problem is that the x86 translation code ignores most of the CPU
feature bits, and implements everything all the time.

While that's true for quite some old features, at least x86_64/amd extensions are usually guarded by efer, which does read the cpuid bits. I'm also trying to do those checks with new features, like the ffxsr one.

(that is btw the reason, applying 1/2 of this series doesn't hurt anyone)

But yes, decoupling the cpu descriptors from qemu emulation capabilities sounds like a good idea. Kqemu and kvm certainly have different masks here ;).

Alex



Paul






reply via email to

[Prev in Thread] Current Thread [Next in Thread]