qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] PATCH: qemu_mallocz(): minus one function and replace c


From: malc
Subject: Re: [Qemu-devel] PATCH: qemu_mallocz(): minus one function and replace calloc() instead malloc()
Date: Wed, 28 Jan 2009 23:00:35 +0300 (MSK)

On Wed, 28 Jan 2009, Lionel Landwerlin wrote:

> Le mercredi 28 janvier 2009 ЪЪ 21:44 +0300, Pavel Vasilyev a ЪЪcrit :
> > May be this better? 
> > 
> > 
> > 
> > --- qemu-malloc.c Base (BASE)
> > +++ qemu-malloc.c Locally Modified (Based On LOCAL)
> > @@ -46,10 +46,9 @@
> >  void *(size_t size)
> >  {
> >      void *ptr;
> > -    ptr = qemu_malloc(size);
> > +    ptr = calloc(1, size);
> >      if (!ptr)
> >          return NULL;
> > -    memset(ptr, 0, size);
> >      return ptr;
> >  }
> >  
> 
> This is allocation in system emulation, Malc patch's was about user
> emulation.

It wasn't mine, it was Gerd Hoffmann, but his submission, while fine
enough for git, left the SVN commit without proper author attribution
(I normally wouldn't have 'spotted by malc' in the commit messages, so
 that was a good enough give away, that the patch wasn't mine)

Sorry Gerd, perhaps it's a good idea to add Signed-off-by lines after
all, if only to know who wrote what.

-- 
mailto:address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]