Re: [Qemu-devel] [PATCH] Add multi-boot kernel loading support

[Nathan Froyd]

On Mon, Feb 02, 2009 at 07:17:18PM +0100, Alexander Graf wrote:
> Nathan Froyd wrote:
> > On Mon, Feb 02, 2009 at 07:08:00PM +0100, Rene Rebe wrote:
> >> +    /* 660f011528000000            lgdt [0x28] */
> >> +    *p++ = 0x66;                /* 32-bit operand size */
> >> +    *p++ = 0x67;                /* 32-bit addr size */
> >> +    *p++ = 0x0f;                /* LGDT [0x128] */
> >> +    *p++ = 0x01;
> >> +    *p++ = 0x15;
> >> +    pgdt=p; /* we calculate the gdt position later */
> >> +    p+=4;
> >>     
> >
> > The comments do not appear to agree with the code here.  (The operands
> > for lgdt are different, at the very least.)
>
> Right, because the operands are actually calculated dynamically. Any
> suggestions on how to improve that? Maybe LGDT [GDT]?

Yes, I think that would be an improvement.  Editing the bytestring to
reflect that would be good, as well.

-Nathan