[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH v2 4/8] qemu:virtio-net: Add a virtqueue for
|
From: |
Alex Williamson |
|
Subject: |
Re: [Qemu-devel] Re: [PATCH v2 4/8] qemu:virtio-net: Add a virtqueue for control commands from the guest |
|
Date: |
Wed, 04 Feb 2009 16:34:06 -0700 |
On Thu, 2009-02-05 at 02:09 +0300, malc wrote:
> On Wed, 4 Feb 2009, Alex Williamson wrote:
>
> [..snip..]
>
> >
> > +static void virtio_net_handle_ctrl(VirtIODevice *vdev, VirtQueue *vq)
> > +{
> > + struct virtio_net_ctrl_hdr ctrl;
> > + virtio_net_ctrl_ack status = VIRTIO_NET_ERR;
> > + VirtQueueElement elem;
> > +
> > + while (virtqueue_pop(vq, &elem)) {
> > + if ((elem.in_num < 1) | (elem.out_num < 1)) {
> ^ intended ?
No, good catch. Thank you.
--
Alex Williamson HP Open Source & Linux Org.
[Qemu-devel] [PATCH v2 5/8] qemu:virtio-net: Add promiscuous and all-multicast mode bits, Alex Williamson, 2009/02/03
[Qemu-devel] [PATCH v2 6/8] qemu:virtio-net: Enable filtering based on MAC, promisc, broadcast and allmulti, Alex Williamson, 2009/02/03
- Re: [Qemu-devel] [PATCH v2 6/8] qemu:virtio-net: Enable filtering based on MAC, promisc, broadcast and allmulti, Blue Swirl, 2009/02/03
- Re: [Qemu-devel] [PATCH v2 6/8] qemu:virtio-net: Enable filtering based on MAC, promisc, broadcast and allmulti, Anthony Liguori, 2009/02/03
- Re: [Qemu-devel] [PATCH v2 6/8] qemu:virtio-net: Enable filtering based on MAC, promisc, broadcast and allmulti, Paul Brook, 2009/02/03
- Re: [Qemu-devel] [PATCH v2 6/8] qemu:virtio-net: Enable filtering based on MAC, promisc, broadcast and allmulti, malc, 2009/02/03
[Qemu-devel] [PATCH v2 7/8] qemu:virtio-net: Add additional MACs via a filter table, Alex Williamson, 2009/02/03
[Qemu-devel] [PATCH v2 8/8] qemu:virtio-net: Add VLAN filtering, Alex Williamson, 2009/02/03