qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 3/9] monitor_readline: poll pending bottom halves be


From: Eduardo Habkost
Subject: [Qemu-devel] [PATCH 3/9] monitor_readline: poll pending bottom halves before readline_start()
Date: Fri, 6 Feb 2009 19:08:54 -0200

monitor_readline() breaks when a CHR_EVENT_RESET event bottom-half is
pending, because the bottom-half resets the console readline state.

Call qemu_bh_poll() before readline_start() to avoid that from
happening.

>From my tests, there is more monitor_readline() badness on the current
code, but this should make things slightly better.

Signed-off-by: Eduardo Habkost <address@hidden>
---
 monitor.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/monitor.c b/monitor.c
index 354a792..138e829 100644
--- a/monitor.c
+++ b/monitor.c
@@ -2862,6 +2862,12 @@ void monitor_readline(const char *prompt, int 
is_password,
         }
     }
 
+    /* Terminal reset events may be pending, and they would
+     * drop the setup done by the readline_start() call
+     * below.
+     */
+    qemu_bh_poll();
+
     readline_start(prompt, is_password, monitor_readline_cb, NULL);
     monitor_readline_buf = buf;
     monitor_readline_buf_size = buf_size;
-- 
1.6.0.2.GIT





reply via email to

[Prev in Thread] Current Thread [Next in Thread]