[Qemu-devel] [PATCH 00/17] monitor rework

[Jan Kiszka]

It started with a tiny patch to improve the various gdb pass-through
proposals that have been posted here before. But the deeper I dug, the
more issues of the monitor terminal concept and implementation showed
up. So this ended up as a major rework. I'm not claiming its perfect but
I think it's a significant improvement. Major contributions are:

 o complete fix for disk passwords
 o non-VM-blocking password retrieval
 o unlimited and fully decoupled monitor terminals
 o monitor pass-through via gdb
 o improved usability of mux'ed monitor terminals

I know some patches are huge and probably hard to review, and I already
worked hard on splitting things up into reasonable functional chunks.
But if someone finds a patch that could be broken into more useful
pieces, just let me know.

Thanks in advance for any review comments!


Find the patches also at git://git.kiszka.org/qemu.git queues/monitor

Jan Kiszka (17):
      block: Polish error handling of brdv_open2
      block: Improve bdrv_iterate
      block: Introduce bdrv_get_encrypted_filename
      monitor: Report encrypted disks in snapshot mode
      monitor: Don't change VNC server when disabled
      char-mux: Use separate input buffers
      monitor: Introduce monitor.h and readline.h
      monitor: Rework initial disk password retrieval
      monitor: Simplify password input mode
      monitor: Rework terminal management
      monitor: Drop banner hiding
      monitor: Rework modal password input
      monitor: Introduce ReadLineState
      monitor: Decouple terminals
      monitor: Improve mux'ed console experience
      monitor: Introduce MONITOR_USE_READLINE flag
      monitor: Pass-through for gdbstub

 audio/audio.c      |    6 +-
 audio/wavcapture.c |   20 +-
 block.c            |  157 ++++++++------
 block.h            |    8 +-
 block_int.h        |    1 +
 console.h          |   27 ---
 disas.c            |   14 +-
 gdbstub.c          |   54 +++++-
 hw/i8259.c         |   16 +-
 hw/pc.c            |    8 +-
 hw/pci.c           |   22 +-
 hw/slavio_intctl.c |   14 +-
 hw/sun4c_intctl.c  |   12 +-
 hw/usb-msd.c       |   10 +-
 hw/usb.h           |    4 +
 migration-exec.c   |   13 +-
 migration-tcp.c    |   13 +-
 migration.c        |   34 ++-
 migration.h        |    4 +-
 monitor.c          |  624 ++++++++++++++++++++++++++++++----------------------
 monitor.h          |   24 ++
 net.c              |   12 +-
 qemu-char.c        |   40 +++--
 qemu-char.h        |    8 +-
 qemu-tool.c        |    6 +-
 readline.c         |  406 +++++++++++++++++-----------------
 readline.h         |   47 ++++
 savevm.c           |   70 +++---
 slirp/misc.c       |    4 +-
 usb-linux.c        |   28 ++-
 vl.c               |  113 ++++------
 vnc.c              |   21 +-
 32 files changed, 1038 insertions(+), 802 deletions(-)
 create mode 100644 monitor.h
 create mode 100644 readline.h