Re: [Qemu-devel] [PATCH] Allow additions of ACPI tables from command line

[Blue Swirl]

On 2/12/09, Gleb Natapov <address@hidden> wrote:
> On Thu, Feb 12, 2009 at 05:53:24PM +0200, Blue Swirl wrote:
>  > On 2/12/09, Gleb Natapov <address@hidden> wrote:
>  > > This is needed to dynamically add SLIC tables with Windows
>  > >  activation keys.
>  >
>  > >  +--- a/bios/rombios32.c
>  > >  ++++ b/bios/rombios32.c
>  > >  +@@ -455,6 +455,8 @@ unsigned long bios_table_end_addr;
>  > >  + #define QEMU_CFG_SIGNATURE  0x00
>  > >  + #define QEMU_CFG_ID         0x01
>  > >  + #define QEMU_CFG_UUID       0x02
>  > >  ++#define FW_CFG_ARCH_LOCAL     0x8000
>  > >  ++#define FW_CFG_ACPI_TABLES  (FW_CFG_ARCH_LOCAL + 0)
>  >
>  > Why don't you just copy the file hw/fw_cfg.h as is? It's designed to
>  > be included even from assembler files.
>  >
>
> Bochs is another project. We can copy the file once but than we will have to
>  sync it each time it changes in qemu anyway.

But we have to sync anyway even if the defines are directly used in
Bochs files. With fw_cfg.h in Bochs, the sync would be 'cp', instead
of manual editing with copy/paste.

OpenBIOS uses verbatim copies of fw_cfg.h and firmware_abi.h.