Re: [Qemu-devel] [PATCH 1/5] kvm/powerpc: Enable MPIC for E500 platform.

[Blue Swirl]

On 2/20/09, Aurelien Jarno <address@hidden> wrote:
> On Tue, Feb 17, 2009 at 04:55:51PM +0200, Blue Swirl wrote:
>  > On 2/17/09, Liu Yu <address@hidden> wrote:
>  > > MPIC and OpenPIC have very similar design.
>  > >  So a lot of code can be reused.
>  > >
>  > >  Modification mainly include:
>  > >  1. keep struct openpic_t to the maximum size of both MPIC and OpenPIC.
>  > >  2. endianess swap.
>  > >    MPIC has the same endianess as target, so no need to swap for MPIC.
>  >
>  > I don't think this is correct, the host can still be different endian
>  > from target.
>  >
>
>
> I do not agree. As long as we don't manipulate host memory, the host
>  endianess has nothing to do. The values are simply passed by value, they
>  don't need to be swapped.

Sorry, I stand corrected.