[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/7] clean build: Fix remaining cris warnings
From: |
Paul Brook |
Subject: |
Re: [Qemu-devel] [PATCH 5/7] clean build: Fix remaining cris warnings |
Date: |
Sat, 21 Feb 2009 23:14:25 +0000 |
User-agent: |
KMail/1.9.9 |
On Saturday 21 February 2009, Stuart Brady wrote:
> On Sat, Feb 21, 2009 at 08:00:55PM +0100, Jan Kiszka wrote:
> > diff --git a/target-cris/translate.c b/target-cris/translate.c
> > index f575e63..954b038 100644
> > --- a/target-cris/translate.c
> > +++ b/target-cris/translate.c
> > @@ -2613,7 +2613,7 @@ static unsigned int dec_move_pm(DisasContext *dc)
> > static unsigned int dec_movem_mr(DisasContext *dc)
> > {
> > TCGv_i64 tmp[16];
> > - TCGv tmp32;
> > + TCGv tmp32 = 0;
> > TCGv addr;
> > int i;
> > int nr = dc->op2 + 1;
>
> Hmm, GCC just gets it wrong here -- and 0 isn't really very meaningful.
Worse than that, 0 is actively wrong. You obviously haven't built with
DEBUG_TCGV.
> At the very least, shouldn't there be a comment? Something like Linux's
> uninitialized_var() macro might be worth considering...
There already is. TCGV_UNUSED.
Paul
- [Qemu-devel] [PATCH 2/7] clean build: Fix irq_info and pic_info related warnings, (continued)
- [Qemu-devel] [PATCH 2/7] clean build: Fix irq_info and pic_info related warnings, Jan Kiszka, 2009/02/21
- [Qemu-devel] [PATCH 7/7] clean build: Fix remaining sh4 warnings, Jan Kiszka, 2009/02/21
- [Qemu-devel] [PATCH 3/7] arm: Fix gic_irq_state.level bitfield type, Jan Kiszka, 2009/02/21
- [Qemu-devel] [PATCH 4/7] clean build: Fix arm build warnings, Jan Kiszka, 2009/02/21
- [Qemu-devel] [PATCH 5/7] clean build: Fix remaining cris warnings, Jan Kiszka, 2009/02/21
- Re: [Qemu-devel] [PATCH 5/7] clean build: Fix remaining cris warnings,
Paul Brook <=
Re: [Qemu-devel] [PATCH 0/7] clean build - eliminate warnings, Laurent Desnogues, 2009/02/21