Re: [Qemu-devel] [PATCH] 64 bit I/O v3

[Blue Swirl]

On 2/26/09, Robert Reif <address@hidden> wrote:
> This is the third version of adding 64 bit I/O support to QEMU.

>   int cpu_register_io_memory(int io_index,
>                             CPUReadMemoryFunc **mem_read,
>                             CPUWriteMemoryFunc **mem_write,
>                             void *opaque)
>   {
>  -    int i, subwidth = 0;
>  +    if (io_index <= 0) {
>  +        io_index = get_free_io_mem_idx();
>  +        if (io_index == -1)
>  +            return io_index;
>  +    } else {
>  +        if (io_index >= IO_MEM_NB_ENTRIES)
>  +            return -1;
>  +    }
>
>  +    io_mem_read[io_index].b = mem_read[0];
>  +    io_mem_write[io_index].b = mem_write[0];
>  +
>  +    io_mem_read[io_index].w = mem_read[1];
>  +    io_mem_write[io_index].w = mem_write[1];
>  +
>  +    io_mem_read[io_index].l = mem_read[2];
>  +    io_mem_write[io_index].l = mem_write[2];
>  +
>  +    io_mem_read[io_index].q = NULL;
>  +    io_mem_write[io_index].q = NULL;
>  +
>  +    io_mem_opaque[io_index] = opaque;
>  +    return (io_index << IO_MEM_SHIFT) | IO_MEM_SUBWIDTH;
>  +}

I think for 64 bit accesses the default should be emulation using two
32 bit accesses instead of NULL (unassigned).