Re: [Qemu-devel] PATCH: 8/9: Support ACLs for controlling VNC access

[Daniel P. Berrange]

On Thu, Feb 26, 2009 at 04:07:45PM -0600, Anthony Liguori wrote:
> >
> >
> > Makefile        |    6 +-
> > b/acl.c         |  168 
> > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > b/acl.h         |   74 ++++++++++++++++++++++++
> > monitor.c       |   95 +++++++++++++++++++++++++++++++
> > vnc-auth-sasl.c |   16 ++++-
> > vnc-auth-sasl.h |    7 ++
> > vnc-tls.c       |   19 ++++++
> > vnc-tls.h       |    3 +
> > vnc.c           |   14 ++++
> > vnc.h           |    3 +
> > 10 files changed, 398 insertions(+), 7 deletions(-)
> >
> >   Signed-off-by: Daniel P. Berrange <address@hidden>
> >  
> 
> This breaks the win32 build.  Attached are the make and config logs.  
> I'm using the F10 mingw packages fwiw.

Ahh, I see one of the Windows system headers define a type called
'ACL' already, so I'll have to adjust that. 

>   CC    vnc.o
> In file included from /home/anthony/git/qemu/vnc-tls.h:34,
>                  from /home/anthony/git/qemu/vnc.h:79,
>                  from /home/anthony/git/qemu/vnc.c:27:
> /home/anthony/git/qemu/acl.h:31: error: conflicting types for 'ACL'
> /usr/i686-pc-mingw32/sys-root/mingw/include/winnt.h:1834: error: previous 
> declaration of 'ACL' was here


Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|