[Qemu-devel] [6646] Missing cirrus_invalidate_region() in cirrus_do_copy() (Brian Kress)

[Anthony Liguori]

Revision: 6646
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6646
Author:   aliguori
Date:     2009-02-27 19:53:57 +0000 (Fri, 27 Feb 2009)

Log Message:
-----------
Missing cirrus_invalidate_region() in cirrus_do_copy() (Brian Kress)

After doing a video to video copy, cirrus_do_copy() in cirrus_vga.c does a
conditional call to cirrus_invalidate_region() with an "if (!notify)" test.
However at this point the blt has already been done so it seems like this call
should be made unconditionally.  The patch below fixes some display update
problems when dragging windows under both X (fedora 10 guest) and a Windows XP
guest.

Signed-off-by: Brian Kress <address@hidden>
Signed-off-by: Anthony Liguori <address@hidden>

Modified Paths:
--------------
    trunk/hw/cirrus_vga.c

Modified: trunk/hw/cirrus_vga.c
===================================================================
--- trunk/hw/cirrus_vga.c       2009-02-26 16:40:31 UTC (rev 6645)
+++ trunk/hw/cirrus_vga.c       2009-02-27 19:53:57 UTC (rev 6646)
@@ -781,10 +781,9 @@
     /* we don't have to notify the display that this portion has
        changed since qemu_console_copy implies this */
 
-    if (!notify)
-       cirrus_invalidate_region(s, s->cirrus_blt_dstaddr,
-                                s->cirrus_blt_dstpitch, s->cirrus_blt_width,
-                                s->cirrus_blt_height);
+    cirrus_invalidate_region(s, s->cirrus_blt_dstaddr,
+                               s->cirrus_blt_dstpitch, s->cirrus_blt_width,
+                               s->cirrus_blt_height);
 }
 
 static int cirrus_bitblt_videotovideo_copy(CirrusVGAState * s)