Re: [Qemu-devel] Re: [PATCH] [RFC] Haiku host support and general configure issues

[Andreas Färber]

Hello,

Am 28.02.2009 um 18:08 schrieb François Revol:

> > We have undocumented --extra-cflags= and --extra-ldflags= options
> > that
> > don't work as expected. They are ignored by all the configure tests,
> > so it seems there is no direct equivalent to autoconf's CPPFLAGS to
> > pass in additional header include paths. The OS_CFLAGS come closest,
> > but they are ignored for some of the tests, too. Any preferences how
> > to fix this?
>
> Ideally those shouldn't be needed anyway.

Not sure what exactly you're referring to, but both OS-specific as  
well as user-supplied settings may be necessary and should be working.  
Command line arguments are necessary to use self-compiled dependency  
libraries in their own prefix, for example.


> > Unresolved issues include that AIO is detected, and as a consequence
>
> Then the test is buggy as we don't have AIO in Haiku that I know of :)

Hm, the so-called AIO check is rather a pthreads check:

#include <pthread.h>
int main(void) { pthread_mutex_t lock;  return 0; }

If that compiles, a working -lpthread is assumed. It's buggy in itself  
because it first sets AIOLIBS="", then compiles with unchanged empty  
$AIOLIBS and then sets AIOLIBS="-lpthread".

> > AIOLIBS is set to -lpthread but that is not available on Haiku.
>
> Well we should have a pthread lib available though...

It's part of libroot.so, I thought, and thus referenced without extra  
linker arguments.


> Another big issue that I mentionned earlier here is the widely used
> assumption that error codes are positive, which is not the case for
> BeOS and Haiku.
> Not fixing this will result in a dangerous binary.

Thanks for the reminder. But that also reminds me, you wanted to  
supply a patch for that! :)

Andreas