Re: [Qemu-devel] [PATCH] VMware SVGA uses incorrect depth

[Stefano Stabellini]

andrzej zaborowski wrote:

> I don't think hardcoding any depth is correct (not counting the
> obvious performance disadvantage).  The s->depth value is what is
> returned by the SVGA_REG_HOST_BITS_PER_PIXEL register, so it should be
> the host's color depth if possible (may be impossible for VNC, but
> easy with SDL), iirc this broke only recently.
> 

The problem is that the SDL frontend is initialized after the graphic
device so it is not possible to get the host resolution from sdl.c at
the time.

That said, I think that setting the vmware svga color depth to

s->depth = 24;
s->bypp = 4;

by default is reasonable since it covers 99% of the cases out there.