qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [6691] Fix cpuid KVM crash on i386 (Lubomir Rintel)


From: Anthony Liguori
Subject: [Qemu-devel] [6691] Fix cpuid KVM crash on i386 (Lubomir Rintel)
Date: Thu, 05 Mar 2009 19:01:54 +0000

Revision: 6691
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6691
Author:   aliguori
Date:     2009-03-05 19:01:53 +0000 (Thu, 05 Mar 2009)
Log Message:
-----------
Fix cpuid KVM crash on i386 (Lubomir Rintel)

Cpuid should return into vec, not overwrite past address in count.
Changeset 6565 broke this.

Signed-off-by: Lubomir Rintel <address@hidden>
Signed-off-by: Anthony Liguori <address@hidden>

Modified Paths:
--------------
    branches/stable_0_10_0/target-i386/helper.c

Modified: branches/stable_0_10_0/target-i386/helper.c
===================================================================
--- branches/stable_0_10_0/target-i386/helper.c 2009-03-05 19:01:46 UTC (rev 
6690)
+++ branches/stable_0_10_0/target-i386/helper.c 2009-03-05 19:01:53 UTC (rev 
6691)
@@ -1421,10 +1421,10 @@
 #else
     asm volatile("pusha \n\t"
                  "cpuid \n\t"
-                 "mov %%eax, 0(%1) \n\t"
-                 "mov %%ebx, 4(%1) \n\t"
-                 "mov %%ecx, 8(%1) \n\t"
-                 "mov %%edx, 12(%1) \n\t"
+                 "mov %%eax, 0(%2) \n\t"
+                 "mov %%ebx, 4(%2) \n\t"
+                 "mov %%ecx, 8(%2) \n\t"
+                 "mov %%edx, 12(%2) \n\t"
                  "popa"
                  : : "a"(function), "c"(count), "S"(vec)
                  : "memory", "cc");





reply via email to

[Prev in Thread] Current Thread [Next in Thread]