Re: [Qemu-devel] [PATCH] Revert "Use the host exit syscall for exiting (Lauro Ramos Venancio)."

[Laurent Desnogues]

On Sat, Mar 7, 2009 at 1:20 PM, Felipe Contreras
<address@hidden> wrote:
> This breaks pthread_join on arm-linux-user.

I am not sure the fix is correct.  If you run tests/testthread.c you'll
notice the thread2 doesn't print the 20 values it should.

BTW it looks like this test doesn't run on i386 and x86_64:  it
ends immediately.


Laurent

> ---
>  linux-user/syscall.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 40eab4e..572fa0a 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -156,7 +156,6 @@ static type name (type1 arg1,type2 arg2,type3 arg3,type4 
> arg4,type5 arg5,   \
>  }
>
>
> -#define __NR_sys_exit __NR_exit
>  #define __NR_sys_uname __NR_uname
>  #define __NR_sys_faccessat __NR_faccessat
>  #define __NR_sys_fchmodat __NR_fchmodat
> @@ -198,7 +197,6 @@ static int gettid(void) {
>     return -ENOSYS;
>  }
>  #endif
> -_syscall1(int,sys_exit,int,status)
>  _syscall1(int,sys_uname,struct new_utsname *,buf)
>  #if defined(TARGET_NR_faccessat) && defined(__NR_faccessat)
>  _syscall4(int,sys_faccessat,int,dirfd,const char 
> *,pathname,int,mode,int,flags)
> @@ -3433,7 +3431,7 @@ abi_long do_syscall(void *cpu_env, int num, abi_long 
> arg1,
>  #endif
>         gdb_exit(cpu_env, arg1);
>         /* XXX: should free thread stack and CPU env */
> -        sys_exit(arg1);
> +        _exit(arg1);
>         ret = 0; /* avoid warning */
>         break;
>     case TARGET_NR_read:
> --
> 1.6.2
>
>
>
>