qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [6768] Use C99 initializers for BlockDriver methods


From: Aurelien Jarno
Subject: [Qemu-devel] [6768] Use C99 initializers for BlockDriver methods
Date: Sat, 07 Mar 2009 22:00:31 +0000

Revision: 6768
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6768
Author:   aurel32
Date:     2009-03-07 22:00:29 +0000 (Sat, 07 Mar 2009)
Log Message:
-----------
Use C99 initializers for BlockDriver methods

Consistently use the C99 named initializer format for the BlockDriver
methods to make the method table more readable and more easily
extensible.

Signed-off-by: Christoph Hellwig <address@hidden>
Signed-off-by: Aurelien Jarno <address@hidden>

Modified Paths:
--------------
    trunk/block-bochs.c
    trunk/block-cloop.c
    trunk/block-cow.c
    trunk/block-dmg.c
    trunk/block-nbd.c
    trunk/block-parallels.c
    trunk/block-qcow.c
    trunk/block-qcow2.c
    trunk/block-raw-posix.c
    trunk/block-raw-win32.c
    trunk/block-vmdk.c
    trunk/block-vpc.c
    trunk/block-vvfat.c

Modified: trunk/block-bochs.c
===================================================================
--- trunk/block-bochs.c 2009-03-07 21:48:08 UTC (rev 6767)
+++ trunk/block-bochs.c 2009-03-07 22:00:29 UTC (rev 6768)
@@ -242,11 +242,10 @@
 }
 
 BlockDriver bdrv_bochs = {
-    "bochs",
-    sizeof(BDRVBochsState),
-    bochs_probe,
-    bochs_open,
-    bochs_read,
-    NULL,
-    bochs_close,
+    .format_name       = "bochs",
+    .instance_size     = sizeof(BDRVBochsState),
+    .bdrv_probe                = bochs_probe,
+    .bdrv_open         = bochs_open,
+    .bdrv_read         = bochs_read,
+    .bdrv_close                = bochs_close,
 };

Modified: trunk/block-cloop.c
===================================================================
--- trunk/block-cloop.c 2009-03-07 21:48:08 UTC (rev 6767)
+++ trunk/block-cloop.c 2009-03-07 22:00:29 UTC (rev 6768)
@@ -154,11 +154,10 @@
 }
 
 BlockDriver bdrv_cloop = {
-    "cloop",
-    sizeof(BDRVCloopState),
-    cloop_probe,
-    cloop_open,
-    cloop_read,
-    NULL,
-    cloop_close,
+    .format_name       = "cloop",
+    .instance_size     = sizeof(BDRVCloopState),
+    .bdrv_probe                = cloop_probe,
+    .bdrv_open         = cloop_open,
+    .bdrv_read         = cloop_read,
+    .bdrv_close                = cloop_close,
 };

Modified: trunk/block-cow.c
===================================================================
--- trunk/block-cow.c   2009-03-07 21:48:08 UTC (rev 6767)
+++ trunk/block-cow.c   2009-03-07 22:00:29 UTC (rev 6768)
@@ -253,15 +253,15 @@
 }
 
 BlockDriver bdrv_cow = {
-    "cow",
-    sizeof(BDRVCowState),
-    cow_probe,
-    cow_open,
-    cow_read,
-    cow_write,
-    cow_close,
-    cow_create,
-    cow_flush,
-    cow_is_allocated,
+    .format_name       = "cow",
+    .instance_size     = sizeof(BDRVCowState),
+    .bdrv_probe                = cow_probe,
+    .bdrv_open         = cow_open,
+    .bdrv_read         = cow_read,
+    .bdrv_write                = cow_write,
+    .bdrv_close                = cow_close,
+    .bdrv_create       = cow_create,
+    .bdrv_flush                = cow_flush,
+    .bdrv_is_allocated = cow_is_allocated,
 };
 #endif

Modified: trunk/block-dmg.c
===================================================================
--- trunk/block-dmg.c   2009-03-07 21:48:08 UTC (rev 6767)
+++ trunk/block-dmg.c   2009-03-07 22:00:29 UTC (rev 6768)
@@ -284,11 +284,10 @@
 }
 
 BlockDriver bdrv_dmg = {
-    "dmg",
-    sizeof(BDRVDMGState),
-    dmg_probe,
-    dmg_open,
-    dmg_read,
-    NULL,
-    dmg_close,
+    .format_name       = "dmg",
+    .instance_size     = sizeof(BDRVDMGState),
+    .bdrv_probe                = dmg_probe,
+    .bdrv_open         = dmg_open,
+    .bdrv_read         = dmg_read,
+    .bdrv_close                = dmg_close,
 };

Modified: trunk/block-nbd.c
===================================================================
--- trunk/block-nbd.c   2009-03-07 21:48:08 UTC (rev 6767)
+++ trunk/block-nbd.c   2009-03-07 22:00:29 UTC (rev 6768)
@@ -177,13 +177,12 @@
 }
 
 BlockDriver bdrv_nbd = {
-    "nbd",
-    sizeof(BDRVNBDState),
-    NULL, /* no probe for protocols */
-    nbd_open,
-    nbd_read,
-    nbd_write,
-    nbd_close,
-    .bdrv_getlength = nbd_getlength,
-    .protocol_name = "nbd",
+    .format_name       = "nbd",
+    .instance_size     = sizeof(BDRVNBDState),
+    .bdrv_open         = nbd_open,
+    .bdrv_read         = nbd_read,
+    .bdrv_write                = nbd_write,
+    .bdrv_close                = nbd_close,
+    .bdrv_getlength    = nbd_getlength,
+    .protocol_name     = "nbd",
 };

Modified: trunk/block-parallels.c
===================================================================
--- trunk/block-parallels.c     2009-03-07 21:48:08 UTC (rev 6767)
+++ trunk/block-parallels.c     2009-03-07 22:00:29 UTC (rev 6768)
@@ -164,11 +164,10 @@
 }
 
 BlockDriver bdrv_parallels = {
-    "parallels",
-    sizeof(BDRVParallelsState),
-    parallels_probe,
-    parallels_open,
-    parallels_read,
-    NULL,
-    parallels_close,
+    .format_name       = "parallels",
+    .instance_size     = sizeof(BDRVParallelsState),
+    .bdrv_probe                = parallels_probe,
+    .bdrv_open         = parallels_open,
+    .bdrv_read         = parallels_read,
+    .bdrv_close                = parallels_close,
 };

Modified: trunk/block-qcow.c
===================================================================
--- trunk/block-qcow.c  2009-03-07 21:48:08 UTC (rev 6767)
+++ trunk/block-qcow.c  2009-03-07 22:00:29 UTC (rev 6768)
@@ -887,23 +887,20 @@
 }
 
 BlockDriver bdrv_qcow = {
-    "qcow",
-    sizeof(BDRVQcowState),
-    qcow_probe,
-    qcow_open,
-    NULL,
-    NULL,
-    qcow_close,
-    qcow_create,
-    qcow_flush,
-    qcow_is_allocated,
-    qcow_set_key,
-    qcow_make_empty,
-
-    .bdrv_aio_read = qcow_aio_read,
-    .bdrv_aio_write = qcow_aio_write,
-    .bdrv_aio_cancel = qcow_aio_cancel,
-    .aiocb_size = sizeof(QCowAIOCB),
+    .format_name       = "qcow",
+    .instance_size     = sizeof(BDRVQcowState),
+    .bdrv_probe                = qcow_probe,
+    .bdrv_open         = qcow_open,
+    .bdrv_close                = qcow_close,
+    .bdrv_create       = qcow_create,
+    .bdrv_flush                = qcow_flush,
+    .bdrv_is_allocated = qcow_is_allocated,
+    .bdrv_set_key      = qcow_set_key,
+    .bdrv_make_empty   = qcow_make_empty,
+    .bdrv_aio_read     = qcow_aio_read,
+    .bdrv_aio_write    = qcow_aio_write,
+    .bdrv_aio_cancel   = qcow_aio_cancel,
+    .aiocb_size                = sizeof(QCowAIOCB),
     .bdrv_write_compressed = qcow_write_compressed,
-    .bdrv_get_info = qcow_get_info,
+    .bdrv_get_info     = qcow_get_info,
 };

Modified: trunk/block-qcow2.c
===================================================================
--- trunk/block-qcow2.c 2009-03-07 21:48:08 UTC (rev 6767)
+++ trunk/block-qcow2.c 2009-03-07 22:00:29 UTC (rev 6768)
@@ -2646,28 +2646,26 @@
 #endif
 
 BlockDriver bdrv_qcow2 = {
-    "qcow2",
-    sizeof(BDRVQcowState),
-    qcow_probe,
-    qcow_open,
-    NULL,
-    NULL,
-    qcow_close,
-    qcow_create,
-    qcow_flush,
-    qcow_is_allocated,
-    qcow_set_key,
-    qcow_make_empty,
+    .format_name       = "qcow2",
+    .instance_size     = sizeof(BDRVQcowState),
+    .bdrv_probe                = qcow_probe,
+    .bdrv_open         = qcow_open,
+    .bdrv_close                = qcow_close,
+    .bdrv_create       = qcow_create,
+    .bdrv_flush                = qcow_flush,
+    .bdrv_is_allocated = qcow_is_allocated,
+    .bdrv_set_key      = qcow_set_key,
+    .bdrv_make_empty   = qcow_make_empty,
 
-    .bdrv_aio_read = qcow_aio_read,
-    .bdrv_aio_write = qcow_aio_write,
-    .bdrv_aio_cancel = qcow_aio_cancel,
-    .aiocb_size = sizeof(QCowAIOCB),
+    .bdrv_aio_read     = qcow_aio_read,
+    .bdrv_aio_write    = qcow_aio_write,
+    .bdrv_aio_cancel   = qcow_aio_cancel,
+    .aiocb_size                = sizeof(QCowAIOCB),
     .bdrv_write_compressed = qcow_write_compressed,
 
     .bdrv_snapshot_create = qcow_snapshot_create,
-    .bdrv_snapshot_goto = qcow_snapshot_goto,
+    .bdrv_snapshot_goto        = qcow_snapshot_goto,
     .bdrv_snapshot_delete = qcow_snapshot_delete,
-    .bdrv_snapshot_list = qcow_snapshot_list,
-    .bdrv_get_info = qcow_get_info,
+    .bdrv_snapshot_list        = qcow_snapshot_list,
+    .bdrv_get_info     = qcow_get_info,
 };

Modified: trunk/block-raw-posix.c
===================================================================
--- trunk/block-raw-posix.c     2009-03-07 21:48:08 UTC (rev 6767)
+++ trunk/block-raw-posix.c     2009-03-07 22:00:29 UTC (rev 6768)
@@ -1180,32 +1180,28 @@
 #endif /* !linux */
 
 BlockDriver bdrv_host_device = {
-    "host_device",
-    sizeof(BDRVRawState),
-    NULL, /* no probe for protocols */
-    hdev_open,
-    NULL,
-    NULL,
-    raw_close,
-    NULL,
-    raw_flush,
+    .format_name       = "host_device",
+    .instance_size     = sizeof(BDRVRawState),
+    .bdrv_open         = hdev_open,
+    .bdrv_close                = raw_close,
+    .bdrv_flush                = raw_flush,
 
 #ifdef CONFIG_AIO
-    .bdrv_aio_read = raw_aio_read,
-    .bdrv_aio_write = raw_aio_write,
-    .bdrv_aio_cancel = raw_aio_cancel,
-    .aiocb_size = sizeof(RawAIOCB),
+    .bdrv_aio_read     = raw_aio_read,
+    .bdrv_aio_write    = raw_aio_write,
+    .bdrv_aio_cancel   = raw_aio_cancel,
+    .aiocb_size                = sizeof(RawAIOCB),
 #endif
 
-    .bdrv_pread = raw_pread,
-    .bdrv_pwrite = raw_pwrite,
-    .bdrv_getlength = raw_getlength,
+    .bdrv_pread                = raw_pread,
+    .bdrv_pwrite       = raw_pwrite,
+    .bdrv_getlength    = raw_getlength,
 
     /* removable device support */
-    .bdrv_is_inserted = raw_is_inserted,
-    .bdrv_media_changed = raw_media_changed,
-    .bdrv_eject = raw_eject,
-    .bdrv_set_locked = raw_set_locked,
+    .bdrv_is_inserted  = raw_is_inserted,
+    .bdrv_media_changed        = raw_media_changed,
+    .bdrv_eject                = raw_eject,
+    .bdrv_set_locked   = raw_set_locked,
     /* generic scsi device */
-    .bdrv_ioctl = raw_ioctl,
+    .bdrv_ioctl                = raw_ioctl,
 };

Modified: trunk/block-raw-win32.c
===================================================================
--- trunk/block-raw-win32.c     2009-03-07 21:48:08 UTC (rev 6767)
+++ trunk/block-raw-win32.c     2009-03-07 22:00:29 UTC (rev 6768)
@@ -495,23 +495,19 @@
 #endif
 
 BlockDriver bdrv_host_device = {
-    "host_device",
-    sizeof(BDRVRawState),
-    NULL, /* no probe for protocols */
-    hdev_open,
-    NULL,
-    NULL,
-    raw_close,
-    NULL,
-    raw_flush,
+    .format_name       = "host_device",
+    .instance_size     = sizeof(BDRVRawState),
+    .bdrv_open         = hdev_open,
+    .bdrv_close                = raw_close,
+    .bdrv_flush                = raw_flush,
 
 #ifdef WIN32_AIO
-    .bdrv_aio_read = raw_aio_read,
-    .bdrv_aio_write = raw_aio_write,
-    .bdrv_aio_cancel = raw_aio_cancel,
-    .aiocb_size = sizeof(RawAIOCB);
+    .bdrv_aio_read     = raw_aio_read,
+    .bdrv_aio_write    = raw_aio_write,
+    .bdrv_aio_cancel   = raw_aio_cancel,
+    .aiocb_size                = sizeof(RawAIOCB);
 #endif
-    .bdrv_pread = raw_pread,
-    .bdrv_pwrite = raw_pwrite,
-    .bdrv_getlength = raw_getlength,
+    .bdrv_pread                = raw_pread,
+    .bdrv_pwrite       = raw_pwrite,
+    .bdrv_getlength    = raw_getlength,
 };

Modified: trunk/block-vmdk.c
===================================================================
--- trunk/block-vmdk.c  2009-03-07 21:48:08 UTC (rev 6767)
+++ trunk/block-vmdk.c  2009-03-07 22:00:29 UTC (rev 6768)
@@ -812,14 +812,14 @@
 }
 
 BlockDriver bdrv_vmdk = {
-    "vmdk",
-    sizeof(BDRVVmdkState),
-    vmdk_probe,
-    vmdk_open,
-    vmdk_read,
-    vmdk_write,
-    vmdk_close,
-    vmdk_create,
-    vmdk_flush,
-    vmdk_is_allocated,
+    .format_name       = "vmdk",
+    .instance_size     = sizeof(BDRVVmdkState),
+    .bdrv_probe                = vmdk_probe,
+    .bdrv_open         = vmdk_open,
+    .bdrv_read         = vmdk_read,
+    .bdrv_write                = vmdk_write,
+    .bdrv_close                = vmdk_close,
+    .bdrv_create       = vmdk_create,
+    .bdrv_flush                = vmdk_flush,
+    .bdrv_is_allocated = vmdk_is_allocated,
 };

Modified: trunk/block-vpc.c
===================================================================
--- trunk/block-vpc.c   2009-03-07 21:48:08 UTC (rev 6767)
+++ trunk/block-vpc.c   2009-03-07 22:00:29 UTC (rev 6768)
@@ -582,12 +582,12 @@
 }
 
 BlockDriver bdrv_vpc = {
-    "vpc",
-    sizeof(BDRVVPCState),
-    vpc_probe,
-    vpc_open,
-    vpc_read,
-    vpc_write,
-    vpc_close,
-    vpc_create,
+    .format_name       = "vpc",
+    .instance_size     = sizeof(BDRVVPCState),
+    .bdrv_probe                = vpc_probe,
+    .bdrv_open         = vpc_open,
+    .bdrv_read         = vpc_read,
+    .bdrv_write                = vpc_write,
+    .bdrv_close                = vpc_close,
+    .bdrv_create       = vpc_create,
 };

Modified: trunk/block-vvfat.c
===================================================================
--- trunk/block-vvfat.c 2009-03-07 21:48:08 UTC (rev 6767)
+++ trunk/block-vvfat.c 2009-03-07 22:00:29 UTC (rev 6768)
@@ -2805,17 +2805,14 @@
 }
 
 BlockDriver bdrv_vvfat = {
-    "vvfat",
-    sizeof(BDRVVVFATState),
-    NULL, /* no probe for protocols */
-    vvfat_open,
-    vvfat_read,
-    vvfat_write,
-    vvfat_close,
-    NULL, /* ??? Not sure if we can do any meaningful flushing.  */
-    NULL,
-    vvfat_is_allocated,
-    .protocol_name = "fat",
+    .format_name       = "vvfat",
+    .instance_size     = sizeof(BDRVVVFATState),
+    .bdrv_open         = vvfat_open,
+    .bdrv_read         = vvfat_read,
+    .bdrv_write                = vvfat_write,
+    .bdrv_close                = vvfat_close,
+    .bdrv_is_allocated = vvfat_is_allocated,
+    .protocol_name     = "fat",
 };
 
 #ifdef DEBUG





reply via email to

[Prev in Thread] Current Thread [Next in Thread]