|
From: | Riihimaki Juha |
Subject: | Re: [Qemu-devel] [PATCH] fix ARMv7 MOV R15, xxx operation |
Date: | Fri, 13 Mar 2009 16:18:21 +0200 |
On Mar 13, 2009, at 13:52, ext Paul Brook wrote:
On Friday 13 March 2009, Riihimaki Juha wrote:The behavior of several ARM mode commands where the destination register is R15 has changed in ARMv7 to mimic the behavior of the BX instruction. While this calls for a little bit wider fix in the code, this patch fixes the issue for the special case of MOV instruction.No. If you want to fix this, do it properly.
Would you like to give an opinion on how it should be implemented? I suppose changing the store_reg and gen_movl_reg_TN functions in target- arm/translate.c to include an extra check when destination is R15 like "if in ARM state and arch >= 7 then bx else..." might do the trick more generally but do you think it introduces the change in a too wide scope?
Juha
[Prev in Thread] | Current Thread | [Next in Thread] |