Re: [Qemu-devel] [PATCH] host_device_remove: remove incorrect check for device name

[Marcelo Tosatti]

ACK, thanks Eduardo.

On Thu, Mar 19, 2009 at 01:11:07PM -0300, Eduardo Habkost wrote:
> There is no need to check for valid prefixes on the the device name
> when removing it. If the device name is found on the vlan client list,
> it can be removed, regardless of the prefix used on its name.
> 
> To reproduce the bug, just run this on the monitor:
> 
>  (qemu) host_net_add user name=foobar
>  (qemu) host_net_remove 0 foobar
>  invalid host network device foobar
>  (qemu)
> 
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
>  net.c |    5 -----
>  1 files changed, 0 insertions(+), 5 deletions(-)
> 
> diff --git a/net.c b/net.c
> index c853daf..395ee4f 100644
> --- a/net.c
> +++ b/net.c
> @@ -1822,11 +1822,6 @@ void net_host_device_remove(Monitor *mon, int vlan_id, 
> const char *device)
>      VLANState *vlan;
>      VLANClientState *vc;
>  
> -    if (!net_host_check_device(device)) {
> -        monitor_printf(mon, "invalid host network device %s\n", device);
> -        return;
> -    }
> -
>      vlan = qemu_find_vlan(vlan_id);
>      if (!vlan) {
>          monitor_printf(mon, "can't find vlan %d\n", vlan_id);
> -- 
> 1.6.1
> 
>