[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] vnc: throttle screen updates.
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/3] vnc: throttle screen updates. |
|
Date: |
Fri, 20 Mar 2009 09:37:46 +0100 |
|
User-agent: |
Thunderbird 2.0.0.19 (X11/20090105) |
Stefano Stabellini wrote:
> I like the idea behind this patch, but I would make force_update an
> unsigned integer instead of a boolean, incrementing it every time we get a
> framebuffer_update_request and decrementing it every time we send a
> reply.
Point being?
Note that we can satisfy multiple update requests in one reply.
Also note that vnc_copy() sets force_update too.
> Secondly we could even move vga_hw_update after:
>
> if (vs->output.offset && !vs->audio_cap && !vs->force_update)
Agreed.
cheers,
Gerd