Re: [Qemu-devel] [PATCH 11/24] Add ali1543 super IO pci device.

[Tristan Gingold]

On Mar 19, 2009, at 5:07 PM, Krumme, Chris wrote:

> Your commit comment says this is a Super IO.
>
> I think a bit of a comment here about the card, which devices are on  
> the
> card etc. would help people who don't have one laying around.

Ok, I will add a short description.  It is simply a south-bridge:
* DMA
* PIC
* PIT
* kbd
* IDE
* USB
* FDC
* 2 serials ports
* 1 parallel port
* PMU

> > +ali1543_t *ali1543_init (PCIBus *bus, int devfn, qemu_irq irq)
> > +{
> > +    ali1543_t *ali;
> > +    uint8_t *pci_conf;
> > +
> > +    ali = (ali1543_t*)pci_register_device(bus, "Ali1543",
> > sizeof(ali1543_t),
> > +                                         devfn, NULL, NULL);
> > +
> > +    pci_conf = ali->pci.config;
> > +
> > +    pci_config_set_vendor_id(pci_conf, PCI_VENDOR_ID_AL);
> > +    pci_config_set_device_id(pci_conf, PCI_DEVICE_ID_AL_M1533);
>
> Is this an enhanced version of a 1533? Is this just a typo?

Yes, should be.  This is not a typo.

> Thanks  Chris