Re: [Qemu-devel] Re: [PATCH] clean build: Add bt-host.h

[andrzej zaborowski]

2009/3/11 Jan Kiszka <address@hidden>:
> andrzej zaborowski wrote:
,,,
>> Is it?
>> struct HCIInfo is defined in net.h so maybe this one belongs there too.
>>
>> I'd much rather turn off the unhelpful warnings, some of them caused
>> developers to add code that is both more hacky and slower.  I also
>> think we could save many header files like the hw/virtio-*.h, at this
>> granularity they don't help with compile times which was the reason
>> vl.h was split.
>
> I think we see so far a net gain from the warnings as several real bugs
> were caught that way.

Some of the warnings are useful and some are just "if leave your house
a brick might fall on your head and you might die" type.

> And in this case the warning pointed out unclean
> header organization (internal API exports mixed up with generic
> bluetooth types). The goal should not be "as few headers as possible"
> but "one header per reasonably partitioned API".

Right, this makes browsing the headers much easier when looking up a
prototype. This change is in the opposite direction.
(and why is it less hacky?)

Cheers