[Qemu-devel] [6866] x86: Add NULL check to lsl (Jan Kiszka)

[Anthony Liguori]

Revision: 6866
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6866
Author:   aliguori
Date:     2009-03-20 16:18:35 +0000 (Fri, 20 Mar 2009)
Log Message:
-----------
x86: Add NULL check to lsl (Jan Kiszka)

According to the Intel specs, lsl performs a check against NULL for the
provided selector, just like lar does. helper_lar() includes the
corresponding code, helper_lsl() was lacking it so far.

Signed-off-by: Jan Kiszka <address@hidden>
Signed-off-by: Anthony Liguori <address@hidden>

Modified Paths:
--------------
    branches/stable_0_10_0/target-i386/op_helper.c

Modified: branches/stable_0_10_0/target-i386/op_helper.c
===================================================================
--- branches/stable_0_10_0/target-i386/op_helper.c      2009-03-20 16:13:50 UTC 
(rev 6865)
+++ branches/stable_0_10_0/target-i386/op_helper.c      2009-03-20 16:18:35 UTC 
(rev 6866)
@@ -3241,6 +3241,8 @@
 
     selector = selector1 & 0xffff;
     eflags = helper_cc_compute_all(CC_OP);
+    if ((selector & 0xfffc) == 0)
+        goto fail;
     if (load_segment(&e1, &e2, selector) != 0)
         goto fail;
     rpl = selector & 3;