|
From: | Andreas Färber |
Subject: | Re: [Qemu-devel] [PATCH] [STABLE] Clean some PCI defines |
Date: | Sun, 22 Mar 2009 13:31:43 +0100 |
Hello, Am 22.03.2009 um 12:46 schrieb Stefan Weil:
Some defines from linux/pci_regs.h had similar, but not the same defines in hw/pci.h (PCI_REVISION_ID / PCI_REVISION, PCI_SUBSYSTEM_VENDOR_ID / PCI_SUBVENDOR_ID, PCI_SUBSYSTEM_ID / PCI_SUBDEVICE_ID). I suggest to use the "standard" from linux/pci_regs.h and replace the "old" Qemu ones. [...] After a migration to the "standard" defines, pci.h could use linux/pci_regs.h which is far more complete.
Please keep in mind that linux/pci_regs.h is most likely not suitable for cross-platform use.
You could of course do #ifdef __linux__ #include <linux/pci_regs.h> #else #define PCI_... 0x1234 ... #endif but then you would still need to sync the two sections. Andreas
[Prev in Thread] | Current Thread | [Next in Thread] |