[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Remove -s flag in Makefile
From: |
Riku Voipio |
Subject: |
Re: [Qemu-devel] [PATCH] Remove -s flag in Makefile |
Date: |
Wed, 25 Mar 2009 21:49:02 +0200 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Wed, Mar 25, 2009 at 03:45:14PM -0300, Glauber Costa wrote:
> install -s is pretty and cute, but makes the binary get into the build
> directory without any debug information. This is bad, and makes glommer
> sad. Also, tools that attempt to extract that data, like fedora debuginfo
> extractor, will fail.
Fully ACK, but you'll want to fix that in Makefile.target too.
> Signed-off-by: Glauber Costa <address@hidden>
> ---
> Makefile | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 82fec80..859614b 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -251,7 +251,7 @@ endif
> install: all $(if $(BUILD_DOCS),install-doc)
> mkdir -p "$(DESTDIR)$(bindir)"
> ifneq ($(TOOLS),)
> - $(INSTALL) -m 755 -s $(TOOLS) "$(DESTDIR)$(bindir)"
> + $(INSTALL) -m 755 $(TOOLS) "$(DESTDIR)$(bindir)"
> endif
> ifneq ($(BLOBS),)
> mkdir -p "$(DESTDIR)$(datadir)"
> --
> 1.6.0.6
>
>
--
"rm -rf" only sounds scary if you don't have backups
- [Qemu-devel] [PATCH] Remove -s flag in Makefile, Glauber Costa, 2009/03/25
- Re: [Qemu-devel] [PATCH] Remove -s flag in Makefile,
Riku Voipio <=
- Re: [Qemu-devel] [PATCH] Remove -s flag in Makefile, Anthony Liguori, 2009/03/25
- Re: [Qemu-devel] [PATCH] Remove -s flag in Makefile, Lennart Sorensen, 2009/03/26
- Re: [Qemu-devel] [PATCH] Remove -s flag in Makefile, Avi Kivity, 2009/03/26
- Re: [Qemu-devel] [PATCH] Remove -s flag in Makefile, M. Warner Losh, 2009/03/26
- Re: [Qemu-devel] [PATCH] Remove -s flag in Makefile, Lennart Sorensen, 2009/03/26
- Re: [Qemu-devel] [PATCH] Remove -s flag in Makefile, Michael Jennings, 2009/03/26
- Re: [Qemu-devel] [PATCH] Remove -s flag in Makefile, M. Warner Losh, 2009/03/26
- Re: [Qemu-devel] [PATCH] Remove -s flag in Makefile, Lennart Sorensen, 2009/03/26
- Re: [Qemu-devel] [PATCH] Remove -s flag in Makefile, M. Warner Losh, 2009/03/26
- Re: [Qemu-devel] [PATCH] Remove -s flag in Makefile, Lennart Sorensen, 2009/03/26