qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] honor IDE_DMA_BUF_SECTORS


From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH] honor IDE_DMA_BUF_SECTORS
Date: Fri, 27 Mar 2009 13:58:20 +0300
User-agent: Thunderbird 2.0.0.21 (X11/20090320)

Samuel Thibault wrote:
But posix read/write does not fit how DMA works.  A request should
either complete fully, or fail, leaving the destination (disk or
memory) in an undefined state.

Sure.  Again, please read what _I_ wrote: I'm not proposing to expose
that into DMA, just make it genericly handled in the block layer.

Okay. I oppose making short reads part of the API. Callers should expect the return code to be either zero, or a failure indication.

If you want generic block layer support, it could come in the form of helpers, that is a block format driver could call bdrv_continue_partial_request(lots, of, parameters) to have the helper advance the iovec and reissue the partially completed request.

--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]