Re: [Qemu-devel] [PATCH] fix ARMv7 data processing instructions

[Laurent Desnogues]

On Fri, Mar 27, 2009 at 12:47 PM, Juha Riihimäki
<address@hidden> wrote:
> Any further comments? Or perhaps import the patch? I made a small
> performance optimization in the new store_reg_bx macro by performing the
> simpler comparison first and the the little bit more expensive comparison
> only if the first comparison is true. At least I have encountered no
> problems in OMAP2 and OMAP3 emulation so far; instead the guest code which
> doesn't run without the patch in OMAP3 now works.

I didn't take a close look at your patch, so I only have a cosmetic comment :)
Wouldn't it be better to use a static inline function instead of a macro for
store_reg_bx?  At least I find it better looking and should not degrade
performance.


Laurent