Re: [Qemu-devel] [PATCH] get roms more room.

[Glauber Costa]

>
> I really like the patch, but I have one questions I can't answer because
> I'm not familiar enough with the Qemu and Bochs BIOS codebase. You can
> find it as inline comment.
>
> Since the patch seems to do what I want, it is
> Acked-by: Carl-Daniel Hailfinger <address@hidden>
>
> If a Signed-off-by line is preferred, I can send that instead.
>
>> ---
>>  hw/pc.c |   27 +++++++++++++++++----------
>>  1 files changed, 17 insertions(+), 10 deletions(-)
>>
>> +     /* Round up vga bios size to the next 2k boundary */
>> +     vga_bios_size = (vga_bios_size + 2047) & ~2047;
>>
>
> If vga_bios_size ever shrinks below 30k, the option ROMs will start
> below 0xc8000 and the Bochs BIOS won't find them. Is that right?
>

Hummm, humm.... /me thinks....

You're actually right. Although it won't happen if our current codebase, it's
a very valid concern. I will send an updated patch soon, hopefully 100 % ready
for inclusion.

Good catch!

-- 
Glauber  Costa.
"Free as in Freedom"
http://glommer.net

"The less confident you are, the more serious you have to act."