qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 0/2] Fix immediate error handling on synthetic a


From: Anthony Liguori
Subject: [Qemu-devel] Re: [PATCH 0/2] Fix immediate error handling on synthetic aios
Date: Sat, 28 Mar 2009 11:11:55 -0500
User-agent: Thunderbird 2.0.0.21 (X11/20090320)

Avi Kivity wrote:
The block layer can signal aio errors in two ways: by calling the completion
function with a negative status code, or by returning a NULL aiocb.  Two of
the synthetic aio implementations (the DMA API and the vectored aio bouncing)
fail to handle the second case correctly, resulting in crashes when
cancellation of a timed out request is attempted.

I think the long term fix is to have the block layer signal errors in just
one way -- by invoking the completion handler with a negative return code --
but in the meanwhile, here are patches that add the required error checking.

Avi Kivity (2):
  Fix vectored aio bounce handling immediate errors
  Fix DMA API when handling an immediate error from block layer

 block.c       |    5 +++++
 dma-helpers.c |   27 +++++++++++++++++++++------
 2 files changed, 26 insertions(+), 6 deletions(-)

Applied all.  Thanks.

Regards,

Anthony Liguori





reply via email to

[Prev in Thread] Current Thread [Next in Thread]