Re: [Qemu-devel] [PATCH 1/4] move PPC insn flags to cpu.h

[Aurelien Jarno]

On Sat, Mar 28, 2009 at 04:07:52PM -0700, Nathan Froyd wrote:
> On Sat, Mar 28, 2009 at 11:58:05PM +0100, Aurelien Jarno wrote:
> > On Sat, Mar 28, 2009 at 02:30:14PM -0700, Nathan Froyd wrote:
> > > It makes more sense to put the flags in the header file than in the
> > > middle of translate.c.
> > 
> > If those definition are not used outside of translate.c, it makes no
> > sense to move them out to a header file included at multiple places.
> > 
> > OTOH, I agree that having them in the middle of translate.c is a bit
> > strange. Maybe we should move them at the top of the file along with
> > other definitions? In that case, GEN_HANDLER* and EXTRACT_HELPER are
> > also good candidates for the move.
> 
> Whether they are placed at the top of translate.c or in cpu.h makes no
> difference for this patch.  I have an implementation of linux-user
> signal handling for PPC32 that I'd like to submit soon, though.  It
> requires knowing what capabilities the CPU supports so it can figure out
> what registers to save while setting up the signal frame.  (Saving the
> floating point registers makes no difference modulo speed, but the save
> areas for the Altivec and SPE registers overlap.)  So in the interest of
> not having to move them twice, I'm lobbying for placing them in cpu.h.
> 

I see. Then it's probably better to skip this patch in this patch series, 
and to add it in the series wrt linux-user changes.

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net