[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] check for bs->drv in bdrv_flush
|
From: |
Christoph Hellwig |
|
Subject: |
Re: [Qemu-devel] [PATCH] check for bs->drv in bdrv_flush |
|
Date: |
Sun, 29 Mar 2009 09:31:40 +0200 |
|
User-agent: |
Mutt/1.3.28i |
On Sat, Mar 28, 2009 at 08:32:35PM -0500, Anthony Liguori wrote:
> Christoph Hellwig wrote:
> >All the bdrv_ helpers should check for bs->drv being zero as that means
> >there is no backend image open. bdrv_flush fails to perform that check
> >and can thus cause NULL pointer dereferences.
> >
> >Found using qemu-io.
> >
>
> Applied. Thanks.
>
> FWIW, I plan to include qemu-io once you rebase the series to use
> IOVectors instead of struct iovec. It looks like a useful tool!
The repost already uses QEMUIOVectors, I'll resend it with a
formal description.