Re: [Qemu-devel] [PATCH] Document Qemu coding style

[Gleb Natapov]

On Mon, Mar 30, 2009 at 05:45:47PM -0400, Lennart Sorensen wrote:
> On Mon, Mar 30, 2009 at 09:28:54PM +0300, Blue Swirl wrote:
> > I'd remove this, braces are not used consistently for one statement blocks.
> 
> Then fix that.  Making the coding style worse just because some people
> have failed to follow it is not the right solution.
> 
> > No, this is the K&R style. Quoting linux/Documentation/CodingStyle:
> > 
> > Heretic people all over the world have claimed that this inconsistency
> > is ...  well ...  inconsistent, but all right-thinking people know that
> > (a) K&R are _right_ and (b) K&R are right.  Besides, functions are
> > special anyway (you can't nest them in C).
> 
> And Linus is wrong for not requiring braces at all times in the kernel. :)
> I don't have much hope of convincing him of that, but he is still wrong.
> 
Try it anyway. Do it on LKML. It will be entertaining.

--
                        Gleb.