Re: [Qemu-devel] [PATCH 3/4] sending NUMA topology to BIOS

[Blue Swirl]

On 3/31/09, Andre Przywara <address@hidden> wrote:
> From: Andre Przywara <address@hidden>
>
>
>  Signed-off-by: Andre Przywara <address@hidden>


>   static void bochs_bios_init(void)

>  +    uint64_t *numa_fw_cfg;

>  +                numa_fw_cfg[i + 1] = j;

>  +        numa_fw_cfg[smp_cpus + 1 + i] = node_mem[i];

>  +    fw_cfg_add_bytes(fw_cfg, FW_CFG_NUMA, (uint8_t*)numa_fw_cfg,
>  +                     (1 + smp_cpus + nb_numa_nodes) * 8);

This would break on a big endian host, please use cpu_to_le64.