qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 3/3] propagate error on failed completion


From: Glauber Costa
Subject: [Qemu-devel] [PATCH 3/3] propagate error on failed completion
Date: Tue, 31 Mar 2009 13:43:09 -0400

migrate_fd_put_ready() calls qemu_savevm_state_complete(),
but the later can fail.

If it happens, re-start the vm and propagate the error up

Based on a patch by Yaniv Kamay

Signed-off-by: Glauber Costa <address@hidden>
CC: Yaniv Kamay <address@hidden>
CC: Dor Laor <address@hidden>
---
 migration.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/migration.c b/migration.c
index b3904b2..d77ebbd 100644
--- a/migration.c
+++ b/migration.c
@@ -224,7 +224,11 @@ void migrate_fd_put_ready(void *opaque)
         vm_stop(0);
 
         bdrv_flush_all();
-        qemu_savevm_state_complete(s->file);
+        if ((qemu_savevm_state_complete(s->file)) < 0) {
+            vm_start();
+            s->state = MIG_STATE_ERROR;
+            return;
+        }
         s->state = MIG_STATE_COMPLETED;
         migrate_fd_cleanup(s);
     }
-- 
1.5.6.6





reply via email to

[Prev in Thread] Current Thread [Next in Thread]