Re: [Qemu-devel] [PATCH 13/17] Strace is now working again with GUEST_BASE support.

[Paul Brook]

On Tuesday 31 March 2009, address@hidden wrote:
> From: Mika Westerberg <address@hidden>
>
> Signed-off-by: Riku Voipio <address@hidden>
> ---
>  linux-user/strace.c    |  170
> ++++++++++++++++++++++++++++++++++++++++++++++++ linux-user/strace.list | 
> 101 +++++++++++++++++-----------
>  2 files changed, 232 insertions(+), 39 deletions(-)

It would help if you included a description of what the patch actually does.

> + * This function locks strings from guest memory and prints
> + * strace output according to format specified in strace.list.

This seems a poor way of implementing this. Much better would be to parse the 
format string and make this happen automatically for %s arguments and/or add 
a new format specifier.

Paul