Re: [Qemu-devel] [PATCH 00/17] linux-user patches in maemo

[Aurelien Jarno]

On Wed, Apr 01, 2009 at 12:31:17PM +0300, Riku Voipio wrote:
> On Tue, Mar 31, 2009 at 10:31:42PM +0000, Paul Brook wrote:
> > > This some of the more cleaner linux-user patches maemo version
> > > of qemu carries. The idea was to setup a "linux-user-for-upstream"
> > > branch to git.maemo.org, but unfortunately the server is refusink
> > > my git pushes ATM.
> 
> > These patches don't seem particularly coherent.
> > Some of them actually depend on preceding patches, others implement 
> > completely 
> > independent features.
> 
> No problem, I can split these to smaller series.
> 
> > In some places you modify code, only to change that code again in a later 
> > patch. For example patch #7 appears to be purely a fix for bugs introduced 
> > by 
> > patch #5
> 
> These specific patches are unmodified patches submitted by Kirill in October
> last year, without anyone complaining.. I'll squash patches together where
> newer ones changes code of older patches.
> 

The one from October are actually a resent of an earlier series. I
haven't look at the one you selected, but from what I remember they have
a lot of unrelated indentation change, making them difficult to review.

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net