|
From: | Avi Kivity |
Subject: | Re: [Qemu-devel] [RFC] Introduce module API to QEMU |
Date: | Fri, 03 Apr 2009 17:53:38 +0300 |
User-agent: | Thunderbird 2.0.0.21 (X11/20090320) |
Anthony Liguori wrote:
Hmm, this raises annother issue - we've got to be extremely careful about ordering. It's not inconcievable that the PCI support code would have constructors (e.g. to register a PCI bus type).Looks like constructor/destructor has explicit support for ordering. Neat.
I'd avoid it. Have the constructor do a *pci_module_table++ = blah and iterate through that later.
I prefer to have the code explicit somewhere rather than gobs of unportable magic. Use it where you have to, but not elsewhere.
-- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.
[Prev in Thread] | Current Thread | [Next in Thread] |