[Qemu-devel] Re: gdbstub user mode : local/unix socket (cf remote pipe connexion addition)

[Jan Kiszka]

Philippe Waille wrote:
> On Thu, Apr 02, 2009 at 03:53:12PM +0200, Philippe Waille wrote:
> 
> I suggest this patch :
> 
> allow unix-domain socket gdb connection in user-mode gdbstub
> (updated version : fix socket address reuse error in my previous patch)

For unknown reasons my comments on the first version didn't made it to the 
list. Find them below, I think they still apply.

Jan

----------

Philippe Waille wrote:
> Hi
> 
>   I failed to add stdio remote pipe connection method to the linux-user 
> gdbstub
> mode. But adding local/unix sockets instead solves the main part of my 
> problem.

Great. Thanks for working on this!

> 
> GDB options :
> -g trcp_portnumber (deprecated, for compatibility)

IMHO we should rather drop with a hard cut this instead of keeping
(potentially) confusing legacy around.

> -gdb tcp::portnumber
> -gdb local::portname

Why not using the standard syntax from the system emulation instead
inventing a new one? Even if you do not support all variations of
qemu-char, at least the corresponding ones should be compatible.

> 
> 
>   Local/unix sockets allow for instance 
> 
>   > qemu-arm -gdb /tmp/my_private_socket_name  executable_file
>   gdb>  target remote | socat stdio unix-connect:/tmp/my_private_socket_name
> 
> Files modified : gdbstub.c gdbstub.h linux-user/main.c  (tar file attached)
> 
> Diff from latest stable release (patch "Rework configuration via
> command line not applied).

If the patches have conflicts, maybe we can stack them. They logically
belong together (at least once we align the syntax :->), so they should
come as a pair.

> 
> Best regards
> Ph. Waille
> 
> --- qemu-0.10.1_modifie/gdbstub.c     2009-04-02 13:04:08.000000000 +0200
> +++ qemu-0.10.1_orig/gdbstub.c        2009-03-22 00:05:48.000000000 +0100

Reversed patch. A simple svn diff (or git diff, whatever you use) might
be a better idea than manual diffing.

Jan


-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux