Re: [Qemu-devel] [PATCH 04/10] fix IPCOP_sem* and implement sem*

[Rtp]

address@hidden writes:

Hi,

> -static inline abi_long do_semctl(int first, int second, int third,
> -                                 abi_long ptr)
> +static inline abi_long do_semctl(int semid, int semnum, int cmd,
> +                                 union target_semun target_su)
>  {
>      union semun arg;
>      struct semid_ds dsarg;
> -    int cmd = third&0xff;
> -    abi_long ret = 0;
> +    unsigned short *array;
> +    struct seminfo seminfo;
> +    abi_long ret = -TARGET_EINVAL;
> +    abi_long err;
> +    cmd &= 0xff;
>  
>      switch( cmd ) {

I'm wondering if it's a good way of handling the IPC_64 flag. afaik this
flag is set to indicate that we're using newer ipc version, so if it's
set, the code may use things like 32bit uids.
Taking this into account, is it possible that falling back to the old
*ctl versions is breaking some applications ?

Thanks,
Arnaud