qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 02/10] xen: backend driver core


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 02/10] xen: backend driver core
Date: Wed, 08 Apr 2009 16:25:37 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090324 Fedora/3.0-2.1.beta2.fc11 Thunderbird/3.0b2

On 04/08/09 15:17, Anthony Liguori wrote:
I meant the public stuff too. I don't like having extern variables all
over the place.

It would be better to have this in a structure that was passed to all of
the backend drivers that they then passed as a context. This will become
more useful down the road too when we start introducing a common device
model and finer grain locking.

The variables are more global xen state, not device / xenbus state. The usage is not limited to the backend drivers, the domain builder code will use them as well. There will never ever be more than one instance of these. I don't see the point of placing them into a struct and passing around a pointer.

cheers,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]