Re: [Qemu-devel] [PATCH 1/6] Allow multiple monitor devices (v2)

[Avi Kivity]

Anthony Liguori wrote:
> > Timestamping doesn't help since the command could have been delayed 
> > in the monitor socket.
> >
> > Further, we're now so deep down the complexity spiral that it has now 
> > become the most complicated piece of code in the entire system.
>
> You certainly cannot believe that, can you?

It was one of my little exaggerations.  But it does look 
disproportionatly complicated compared to the problem we're trying to solve.

> >   Surely the best way to synchronize events is to keep them on one 
> > timeline?
>
> Can you show exactly how you would expect things to work in the 
> monitor output?  I'm having a hard time understanding what you're 
> suggesting.

(qemu) notify enospace on
(qemu) notify vnc-connect on
(qemu)
notification: vnc connection ...
(qemu) notify migration-completion on
(qemu) migrate -d ...
notification: enospc on ide0-0
(qemu) migrate_cancel
notification: migration cancelled
(qemu) migrate -d ...
(qemu)
notification: migration completed


--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.