Re: [Qemu-devel] Re: [PATCH] register a single area for vga bios and option roms

[Zachary Amsden]

Anthony Liguori wrote:
> Glauber Costa wrote:
>> Those guys are not different in nature. They're all roms,
>> not blessed with the graces of being written to. So there's
>> not need to issue multiple requests to memory registration areas:
>> just treat them as brothers, and put them all in the same
>> region.
>>
>> It also has the nice side effect of improving the loading code
>> a little bit.
>>
>> Signed-off-by: Glauber Costa <address@hidden>
>>   
> 
> The vga bios is just an option rom, right?  So why can't we treat the
> vga bios as an option rom and eliminate the specific code for dealing
> with VGA bios.
> 
> The real problem here is that we should be registering the option rom
> space once and doing that in page boundaries.

Um... are we sure about this?  First off, option roms can be written to,
it's part of the PnP option ROM spec.. they are to be backed in RAM and
the init code will actually write to the ROM to resize it (allowing it
to jettison startup / init code); they get remapped read-only again
later.  Will registering the roms as one physical memory region prevent
this possibility?  Sorry I am still naive and coming up to speed on qemu
if this is a naive question.

Second thing, option roms are not necessarily on page boundaries,
technically they are mapped in chunks, which are 512 byte blocks, at the
discretion of the BIOS / chipset.  This is mostly a non-issue as all
modern BIOS will map them on page boundaries but worth noting.

Zach