[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/7] net: Fix -net socket,listen
From: |
Mark McLoughlin |
Subject: |
Re: [Qemu-devel] [PATCH 1/7] net: Fix -net socket,listen |
Date: |
Wed, 15 Apr 2009 14:09:32 +0100 |
On Tue, 2009-04-14 at 19:29 +0200, Jan Kiszka wrote:
> In case no symbolic name is provided when requesting VLAN connection via
> listening TCP socket ('-net socket,listen=...'), qemu crashes. This
> fixes the cause.
>
> Signed-off-by: Jan Kiszka <address@hidden>
> ---
>
> net.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net.c b/net.c
> index 5365891..c7e4a0b 100644
> --- a/net.c
> +++ b/net.c
> @@ -1440,7 +1440,7 @@ static int net_socket_listen_init(VLANState *vlan,
> }
> s->vlan = vlan;
> s->model = strdup(model);
> - s->name = strdup(name);
> + s->name = name ? strdup(name) : NULL;
Yep, this is a slightly unusual case because we're not allocating a
VLANClientState here which would cause a default name to be assigned.
Acked-by: Mark McLoughlin <address@hidden>
Cheers,
Mark.
- [Qemu-devel] [PATCH 0/7] Various small networking improvements, Jan Kiszka, 2009/04/14
- [Qemu-devel] [PATCH 4/7] net: Prevent multiple slirp instances, Jan Kiszka, 2009/04/14
- [Qemu-devel] [PATCH 1/7] net: Fix -net socket,listen, Jan Kiszka, 2009/04/14
- Re: [Qemu-devel] [PATCH 1/7] net: Fix -net socket,listen,
Mark McLoughlin <=
- [Qemu-devel] [PATCH 2/7] net: Add VLAN client cleanup handler, Jan Kiszka, 2009/04/14
- [Qemu-devel] Re: [PATCH 2/7] net: Add VLAN client cleanup handler, Jan Kiszka, 2009/04/15
- [Qemu-devel] Re: [PATCH 2/7] net: Add VLAN client cleanup handler, Mark McLoughlin, 2009/04/15
- [Qemu-devel] Re: [PATCH 2/7] net: Add VLAN client cleanup handler, Jan Kiszka, 2009/04/15
[Qemu-devel] [PATCH 3/7] net: Check device passed to host_net_remove, Jan Kiszka, 2009/04/14