Re: [Qemu-devel] [PATCH 6/7] net: Add support for capturing VLANs

[Mark McLoughlin]

On Tue, 2009-04-14 at 19:29 +0200, Jan Kiszka wrote:
> This patch is derived from Tristan Gingold's patch. It adds a new VLAN
> client type that writes all traffic on the VLAN it is attached to into a
> pcap file. Such a file can then be analyzed offline with Wireshark or
> tcpdump.

Personally, I'd use a tap device and 'tcpdump -w' to do this.

Any particular reason to add support to qemu itself other than
convenience?

> Besides rebasing and some minor cleanups, the major differences to the
> original version are:
>  - support for enabling/disabling via the monitor (host_net_add/remove)
>  - always register dump client at the head of a VLAN queue
>    (instead of special handling for slirp)

Could you explain why you need this? 

I'd prefer if we didn't have to add qemu_new_vlan_head_client()

Cheers,
Mark.