[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 2/7] net: Add VLAN client cleanup handler
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [PATCH 2/7] net: Add VLAN client cleanup handler |
Date: |
Wed, 15 Apr 2009 19:03:49 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Mark McLoughlin wrote:
> On Wed, 2009-04-15 at 16:04 +0200, Jan Kiszka wrote:
>> Mark McLoughlin wrote:
>>
>>> - Rather than adding yet another param to new_vlan_client(), I just
>>> initialize vc->cleanup after creating the client; another patch in
>>> my queue removes all callbacks to new_vlan_client() because as more
>>> are added it just gets terribly unwieldy.
>> Personally, I prefer a function-based API over, well, hacking the
>> structures directly. The driver should not have to poke into its device
>> descriptor.
>
> I see this as similar to filing out a vtable. Perhaps it makes sense to
> split the function pointers out into a separate struct.
>
>> Yes, this breaks existing code each time you add another
>> callback, but this has the effect that you
>> a) normally think twice if you really need it before doing this,
>> b) likely enhance all users, and
>> c) that new users will find prominent information about this
>> (hopefully) useful callback.
>
> The way I see it is that often when you're adding a new callback, you
> don't want to require all users to implement it. Instead you make sure
> there is a reasonable default behaviour for when the callback is NULL,
> and only set it to non-NULL for the users that really need it.
Based on our patches, one could easily argue that the cleanup handler
does not fall into this category - nearly everyone wants it, no?
Jan
--
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux
- Re: [Qemu-devel] [PATCH 4/7] net: Prevent multiple slirp instances, (continued)
- [Qemu-devel] [PATCH 1/7] net: Fix -net socket,listen, Jan Kiszka, 2009/04/14
- [Qemu-devel] [PATCH 2/7] net: Add VLAN client cleanup handler, Jan Kiszka, 2009/04/14
- [Qemu-devel] Re: [PATCH 2/7] net: Add VLAN client cleanup handler, Jan Kiszka, 2009/04/15
- [Qemu-devel] Re: [PATCH 2/7] net: Add VLAN client cleanup handler, Mark McLoughlin, 2009/04/15
- [Qemu-devel] Re: [PATCH 2/7] net: Add VLAN client cleanup handler,
Jan Kiszka <=
[Qemu-devel] [PATCH 3/7] net: Check device passed to host_net_remove, Jan Kiszka, 2009/04/14
[Qemu-devel] [PATCH 7/7] slirp: Handle DHCP requests for specific IP, Jan Kiszka, 2009/04/14
[Qemu-devel] [PATCH 5/7] monitor: Improve host_net_add, Jan Kiszka, 2009/04/14
[Qemu-devel] [PATCH 6/7] net: Add support for capturing VLANs, Jan Kiszka, 2009/04/14