[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/5] qcow2: Fix warnings in check_refcount()
From: |
Ryan Harper |
Subject: |
Re: [Qemu-devel] [PATCH 1/5] qcow2: Fix warnings in check_refcount() |
Date: |
Fri, 17 Apr 2009 19:11:11 -0500 |
User-agent: |
Mutt/1.5.6+20040907i |
* Anthony Liguori <address@hidden> [2009-04-17 17:38]:
> Kevin Wolf wrote:
> >Am Samstag, 18. April 2009 00:07 schrieben Sie:
> >
> >>Every patch I commit gets tested. I have various tests that I run
> >>depending on which subsystem the patch touches. Right now, for qcow2, I
> >>don't have nearly enough. I was hoping that Christoph had something
> >>laying around that I could use since it looks like qemu-io would be a
> >>great harness for qcow2 changes.
> >>
> >
> >It is, definitely. qemu-io is the other part which I needed. But qemu-io
> >alone won't make you happy. It can exercise a lot of code, but it can't
> >tell you if your image is broken in the end. Except for reading back
> >written data, of course, but breakage is often enough more subtle.
> >
> >
> >>But I can write a pretty easy script myself on top of qemu-io so it's no
> >>big deal. I'm not suggesting holding up development.
> >>
> >
> >Heh, so everyone is writing his own scripts. What would you think about
> >bringing the test cases you use into the repository?
> >
>
> Yeah, I've been wanting to do everything via kvm-autotest but so far,
> it's not quite up to what I want to use it for. I'll see about cleaning
> up some of my scripts and posting them. The problem is they rely on
> custom images.
If you post em, I'm sure we can work it in.
--
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
address@hidden
- [Qemu-devel] [PATCH 2/5] Introduce bdrv_check, (continued)
- [Qemu-devel] [PATCH 2/5] Introduce bdrv_check, kwolf, 2009/04/17
- [Qemu-devel] [PATCH 3/5] Introduce qemu-img check subcommand, kwolf, 2009/04/17
- [Qemu-devel] [PATCH 1/5] qcow2: Fix warnings in check_refcount(), kwolf, 2009/04/17
- Re: [Qemu-devel] [PATCH 1/5] qcow2: Fix warnings in check_refcount(), Anthony Liguori, 2009/04/17
- Re: [Qemu-devel] [PATCH 1/5] qcow2: Fix warnings in check_refcount(), Kevin Wolf, 2009/04/17
- Re: [Qemu-devel] [PATCH 1/5] qcow2: Fix warnings in check_refcount(), Anthony Liguori, 2009/04/17
- Re: [Qemu-devel] [PATCH 1/5] qcow2: Fix warnings in check_refcount(), Kevin Wolf, 2009/04/17
- Re: [Qemu-devel] [PATCH 1/5] qcow2: Fix warnings in check_refcount(), Anthony Liguori, 2009/04/17
- Re: [Qemu-devel] [PATCH 1/5] qcow2: Fix warnings in check_refcount(), Kevin Wolf, 2009/04/17
- Re: [Qemu-devel] [PATCH 1/5] qcow2: Fix warnings in check_refcount(), Anthony Liguori, 2009/04/17
- Re: [Qemu-devel] [PATCH 1/5] qcow2: Fix warnings in check_refcount(),
Ryan Harper <=
- Re: [Qemu-devel] [PATCH 1/5] qcow2: Fix warnings in check_refcount(), Christoph Hellwig, 2009/04/20
- Re: [Qemu-devel] [PATCH 1/5] qcow2: Fix warnings in check_refcount(), Kevin Wolf, 2009/04/21
- Re: [Qemu-devel] [PATCH 1/5] qcow2: Fix warnings in check_refcount(), Christoph Hellwig, 2009/04/20
Re: [Qemu-devel] [PATCH 1/5] qcow2: Fix warnings in check_refcount(), Anthony Liguori, 2009/04/21
[Qemu-devel] [PATCH 4/5] qcow2: Refcount checking code cleanup, kwolf, 2009/04/17
[Qemu-devel] [PATCH 5/5] qcow2: Add plausibility check for L1/L2 entries, kwolf, 2009/04/17
Re: [Qemu-devel] [PATCH 0/5] Add qemu-img check subcommand, Gleb Natapov, 2009/04/20