Re: [Qemu-devel] [PATCH, RFC] Add file describing rules for submitting patches

[Andreas Färber]

Am 19.04.2009 um 18:59 schrieb Blue Swirl:

> On 4/19/09, Avi Kivity <address@hidden> wrote:
> > Blue Swirl wrote:
> >
> > > Hi,
> > >
> > > I gathered a few common complaints about patch submission, hopefully
> > > not too much affected by my consumption of small amounts of various
> > > alcoholic substances.
>
> > > +
> > > +SP4.4: The patches targeted for development branch must be based on
> > > +the current development repository
> > > +
> > > +SP4.5: The patches targeted for stable branch must be based on the
> > > +current stable repository
> >
> > Suggest instead: patches should state which branch they are based  
> > on, and
> > should be based on a recent version of the branch.
>
> I'd suppose most of the patches are for the development branch, so one
> of the subject tags could be "STABLE" indicating stable branch.
> Without it dev branch is assumed.

4.5. -- I'd suspect that for most patches for STABLE it's not  
necessary to send them twice, once against the stable branch, when  
they can easily be cherry-picked or patch -p1'ed. Please consider  
"should" or "must ... if it differs from devel branch" there.

2.4 -- Do comments after --- line have to be space-indented or not for  
inline patches?

6.2 -- "as opposed to individual patch descriptions" may sound  
misleading, suggest "in addition to individual patch descriptions".

Andreas